dynamically intern strings at runtime #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This somehow didn't regress test262 but actually ended up making two more tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been interning (constant) strings in the frontend (pre-VM) for quite a while, but we always threw them away and turned them into
Rc<str>s in the compiler. This PR changes it to keep strings interned all the way up until including the vm. It also dynamically interns strings and tries to recycle unused ones with a free list.One of the big upsides here is that the
Valueenum is now effectively dropless, which will have a positive impact on e.g. returning from functions when the vm mass splices values off the stack (which can now just compile to decrementing the length).It also brings us one step closer to a smaller
Valuetype (hasn't changed it though)